Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add autoloading zsh completion #810

Closed
fawaf opened this issue Mar 28, 2019 · 6 comments
Closed

add autoloading zsh completion #810

fawaf opened this issue Mar 28, 2019 · 6 comments
Labels
area/v2 relates to / is being considered for v2 help wanted please help if you can! kind/feature describes a code enhancement / feature request status/confirmed confirmed to be valid, but work has yet to start

Comments

@fawaf
Copy link
Contributor

fawaf commented Mar 28, 2019

#compdef $PROG needs to be added to the first line of the zsh completion file to support autoloading.

https://github.com/urfave/cli/blob/master/autocomplete/zsh_autocomplete
@coilysiren coilysiren added help wanted please help if you can! status/confirmed confirmed to be valid, but work has yet to start kind/feature describes a code enhancement / feature request labels Aug 3, 2019
@coilysiren
Copy link
Member

I don't know how zsh completion works offhand, but it looks like this should be an easy change! Do you want to add it @gnowxilef?

@fawaf
Copy link
Contributor Author

fawaf commented Aug 6, 2019

sure, i'll work on it when i get some time.

@coilysiren coilysiren mentioned this issue Aug 17, 2019
Closed
@coilysiren coilysiren added status/claimed someone has claimed this issue and removed status/confirmed confirmed to be valid, but work has yet to start labels Aug 17, 2019
@coilysiren
Copy link
Member

Unassigning since it's been a few weeks! This issue is up for grabs again ^^

@coilysiren coilysiren added status/confirmed confirmed to be valid, but work has yet to start and removed status/claimed someone has claimed this issue labels Sep 10, 2019
@coilysiren coilysiren added the area/v2 relates to / is being considered for v2 label Nov 27, 2019
@ruzaikr
Copy link

ruzaikr commented Dec 9, 2019

Let me give this a shot! @lynncyrin

@coilysiren
Copy link
Member

@ruzaikr after #984 is done, sure!

@fawaf
Copy link
Contributor Author

fawaf commented Dec 9, 2019

oh, this is already taken care of by #906.

@fawaf fawaf closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/v2 relates to / is being considered for v2 help wanted please help if you can! kind/feature describes a code enhancement / feature request status/confirmed confirmed to be valid, but work has yet to start
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fawaf @coilysiren @ruzaikr