Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will V2 ever be released? #805

Closed
marwan-at-work opened this issue Mar 2, 2019 · 24 comments
Closed

Will V2 ever be released? #805

marwan-at-work opened this issue Mar 2, 2019 · 24 comments

Comments

@marwan-at-work
Copy link
Contributor

marwan-at-work commented Mar 2, 2019

The last commit in the v2 branch was over a year ago. Will v2 ever be officially released?

@cvigo
Copy link

cvigo commented Mar 2, 2019

Many think the project is abandoned

@marwan-at-work
Copy link
Contributor Author

That's unfortunate. The V2 API is by far my favorite in comparison to other CLIs

@yihuaf
Copy link

yihuaf commented Mar 29, 2019

Is there a fork being maintained? What's the alternative? I really like the api as well and would hate to see this get's abandoned.

@asahasrabuddhe
Copy link
Member

This library is one of my favorites! I'll try to fork and do my bit. Let's see how it goes!

@marwan-at-work
Copy link
Contributor Author

marwan-at-work commented Apr 2, 2019

I think if any of the urfave team members could give those who like to maintain this project admin access, that would ideal. Then people will continue to use the same exact package and not forks of it.

@asahasrabuddhe
Copy link
Member

I will try to contact the original team members and see where it leads to.

@patrickbsf
Copy link

@asahasrabuddhe any news? I agree that this is one the nicer CLI libraries available. It would be nice to get it back into a maintained fork with proper go modules and go context support.

@kneal
Copy link

kneal commented Jun 13, 2019

We still waiting to here from maintainers?

@coilysiren
Copy link
Member

👋 heya! We've got a few people who'd be interested in contributing to this project (including myself!) Might any of the existing maintainers be able to help us along / provide context? I'm gonna cast a wide net with my pings here - I like this CLI and definitely want to see it be improved!

cc @codegangsta / @meatballhat / @AudriusButkevicius / @blaubaer / @jszwedko / @gravis / @jamescun / @muraty / @thesyncim / @tianon / @txgruppi

@marwan-at-work
Copy link
Contributor Author

@klauern
Copy link

klauern commented Aug 1, 2019

Whatever the end result is, please link to the fork in this issue so I know where to update my import paths. This is a fun, useful library, and I'll go wherever the developers are.

@AudriusButkevicius
Copy link
Contributor

AudriusButkevicius commented Aug 1, 2019

Everyone is free to fork it, have a v2 and maintain it.
There is a ton of PRs outstanding and no clear maintainer.

If you want to maintain this, you should speak up.
Sadly, I don't think I qualify as someone who can hand admin rights over, as my contribution is pretty much a single PR early on.

If there are particular PRs you want me to have a look shout, but I do not intend to properly maintain this.

@marwan-at-work
Copy link
Contributor Author

@AudriusButkevicius see this comment: #805 (comment)

It would be best to hand over admin rights than to fork it so that we don't break users

That said, forking the repo is not a bad back up if no maintainer is willing to hand over rights to those in the community willing to maintain it.

Thanks

@AudriusButkevicius
Copy link
Contributor

AudriusButkevicius commented Aug 1, 2019

I can see there are 5 people with owner rights, one of them is me, other two haven't had any activity in the last year, the two that had activity are @meatballhat and @jszwedko.

I guess I could add new members as non-admins and let them drive this and see how this goes.

@AudriusButkevicius
Copy link
Contributor

AudriusButkevicius commented Aug 1, 2019

I've created a new team, enabled enforcement of PR review by atleast 2 people, so ideally would like to gather multiple people, ideally from different companies (or rather, unrelated with no shared agenda to plant backdoors) etc to drive this forward.

If we don't get the candidates stepping up, I guess we can drop it down to 1.
I don't however want "yolo I do whatever I want, self approve PRs and force push to master" stuff.

@gravis
Copy link
Member

gravis commented Aug 1, 2019

I don't see myself maintaining the V2, I just won't have enough time :(

@marwan-at-work
Copy link
Contributor Author

@AudriusButkevicius that sounds great. We can start with adding @lynncyrin to the team (if you are still willing to contribute!) and whoever was also willing to make the version 2 release happen.

@asahasrabuddhe
Copy link
Member

I am willing to put in the effort and contribute!

@coilysiren
Copy link
Member

We can start with adding @lynncyrin to the team (if you are still willing to contribute!) and whoever was also willing to make the version 2 release happen.

🤚 I'm very interested! I've been wanting a go package to work on ^^

@coilysiren
Copy link
Member

I've created a new team, enabled enforcement of PR review by atleast 2 people, so ideally would like to gather multiple people, ideally from different companies (or rather, unrelated with no shared agenda to plant backdoors) etc to drive this forward.

This is great thinking @AudriusButkevicius 👍👍👍

@coilysiren
Copy link
Member

coilysiren commented Aug 2, 2019

If anyone is interested in having a lower latency conversation about this, I'm in the gophers slack! It's pretty nice https://invite.slack.golangbridge.org/

@AudriusButkevicius
Copy link
Contributor

I've invited you two to the team, let me know if you are able to review and close PRs. I thimk the first step would be to deal with the backlog of PRs.

@coilysiren
Copy link
Member

🎉📈🎉

I also consider open PRs my top priority! The triage order that I used when working on Bundler was

  1. new open PRs
  2. old open PRs
  3. new issues
  4. old issues
  5. epics (like V2)

So it may be a while before I starting this particular issue (eg. V2), but "a while" here means "just a few weeks" 🙂

@coilysiren
Copy link
Member

To answer the title,

Will V2 ever be released?

Yes it will be! You can talk about that here => #826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants