We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go generate
v2
The generation step when calling make from https://cli.urfave.org/CONTRIBUTING/#development-workflow takes way too much detours.
make
graph LR make --> build.go --> gogen[go generate] --> cli.go --> urfave-cli-genflags/make --> urfave-cli-genflags --> goimports
At least this.
graph LR make --> build.go --> urfave-cli-genflags/make --> urfave-cli-genflags --> goimports
urfave-cli-genflags
go build
Did I miss anything?
Yup. If there is no some hidden magic behind.
The text was updated successfully, but these errors were encountered:
@abitrolly Do you really want to optimize this since we are moving forward with v3 ? Does the analysis apply to v3 ?
Sorry, something went wrong.
@dearchap yes. That will make v2 maintenance easier. In case somebody needs to build it with modifications for debug.
v3 doesn't seem the be affected.
No branches or pull requests
My urfave/cli version is
v2
Checklist
Dependency Management
Describe the bug
The generation step when calling
make
from https://cli.urfave.org/CONTRIBUTING/#development-workflow takes way too much detours.Observed behavior
Expected behavior
At least this.
Additional context
go generate
except callingmake
fromurfave-cli-genflags
go generate
is not called duringgo build
process, so there is no implicit automation hereDid I miss anything?
Want to fix this yourself?
Yup. If there is no some hidden magic behind.
The text was updated successfully, but these errors were encountered: