Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] do fix CI #1384

Merged
merged 2 commits into from May 4, 2022
Merged

[v1] do fix CI #1384

merged 2 commits into from May 4, 2022

Conversation

kolyshkin
Copy link
Contributor

What type of PR is this?

  • bug

What this PR does / why we need it:

This really fixes the CI for v1 branch. The previous attempt at that (#1379) fell short
due to two issues; both are fixed here.

Which issue(s) this PR fixes:

none

Special notes for your reviewer:

none

Testing

Check the CI.

Release Notes

none

An earlier commit 6564c0f made an attempt at fixing this test,
but apparently it is not working correctly with Go <= 1.16, because
the panic is expected, and it only happens with Go 1.17+.

Rather than adding an ugly kludge checking the runtime go version,
let's have two versions of the test.

Once Go 1.16 is no longer supported, we can remove the go116_test.go
file.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Due to an issue with commit 6564c0f, only the first line was
executed, so the tests were not executed on GHA CI.

Fixes: 6564c0f
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

Working fine now.

Go 1.16 run:

=== RUN   TestApp_RunAsSubCommandIncorrectUsage
--- PASS: TestApp_RunAsSubCommandIncorrectUsage (0.00s)

Go 1.17 and Go 1.18 runs:

=== RUN   TestApp_RunAsSubCommandIncorrectUsage
flag "--foo" begins with -
--- PASS: TestApp_RunAsSubCommandIncorrectUsage (0.00s)

@kolyshkin kolyshkin marked this pull request as ready for review May 3, 2022 02:36
@kolyshkin kolyshkin requested a review from a team as a code owner May 3, 2022 02:36
@kolyshkin
Copy link
Contributor Author

@meatballhat PTAL (sorry, it's my fault). Once merged, I will rebase #1383 and make it ready for review and merge.

Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@meatballhat meatballhat merged commit 9810d12 into urfave:v1 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants