New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add urfave_cli_no_docs
build tag
#1375
Conversation
This is in preparation to make docs optional. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This removes the resulting binary dependency on cpuguy83/md2man and russross/blackfriday, which saves more than 400 KB (more than 300 KB once stripped) from the resulting binary. Document this in README.
We run test with the tag set (to make sure nothing is broken), and also the check-binary-size target (for informational purposes only). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Result of check-binary-size CI job, defaults:
Same with
Are we planning on v3 yet? In there, we can move docs to a separate package, so it won't be compiled in unless explicitly included. |
🎉 🤘🏼
Added to the list! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
v1 backport: #1383 |
What type of PR is this?
What this PR does / why we need it:
Add urfave_cli_no_docs build tag
This removes the resulting binary dependency on cpuguy83/md2man and
russross/blackfriday, which saves more than 400 KB (more than 300 KB
once stripped) from the resulting binary.
Which issue(s) this PR fixes:
none (although see some discussions in e.g. #1055)
Special notes for your reviewer:
none
Testing
See last commit.
Release Notes