Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused code #1374

Merged
merged 1 commit into from Apr 26, 2022
Merged

Remove some unused code #1374

merged 1 commit into from Apr 26, 2022

Conversation

kbakdev
Copy link
Contributor

@kbakdev kbakdev commented Apr 25, 2022

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Cause it's removing unused pointers, and functions

Testing

> go test

@kbakdev kbakdev requested a review from a team as a code owner April 25, 2022 17:13
@meatballhat meatballhat added this to the Release 2.4.x milestone Apr 26, 2022
@meatballhat meatballhat added area/v2 relates to / is being considered for v2 kind/cleanup describes internal cleanup / maintaince labels Apr 26, 2022
@meatballhat meatballhat changed the title fix: clean code Remove some unused code Apr 26, 2022
@meatballhat meatballhat merged commit dbeef68 into urfave:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dearchap dearchap dearchap approved these changes

Assignees
No one assigned
Labels
area/v2 relates to / is being considered for v2 kind/cleanup describes internal cleanup / maintaince
Projects
None yet
Milestone
Release 2.4.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kbakdev @dearchap @meatballhat