Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nil pointer when getting context's flagSet(#1325) #1327

Merged
merged 2 commits into from Jan 17, 2022
Merged

fix: Nil pointer when getting context's flagSet(#1325) #1327

merged 2 commits into from Jan 17, 2022

Conversation

WUST-mengqinyu
Copy link
Contributor

What type of PR is this?

  • bug

What this PR does / why we need it:

Nil pointer panic when getting cli/context flagSet in UsageError function

Which issue(s) this PR fixes:

Fixes #1325

Release Notes

NONE

@WUST-mengqinyu WUST-mengqinyu requested a review from a team as a code owner January 14, 2022 03:04
saschagrunert
saschagrunert previously approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rliebz rliebz merged commit e855c4c into urfave:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rliebz rliebz rliebz approved these changes

@saschagrunert saschagrunert saschagrunert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nil pointer when getting context's flagSet in UsageError function.
3 participants
@WUST-mengqinyu @saschagrunert @rliebz