Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version range in CI to 1.15-1.17 #1323

Merged
merged 1 commit into from Jan 24, 2022

Conversation

rliebz
Copy link
Member

@rliebz rliebz commented Jan 4, 2022

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

Only support latest 3 versions, and more urgently, stop the binary size from failing CI on Go 1.14 (which we presumably no longer care about).

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)

NONE

@rliebz rliebz requested a review from a team as a code owner January 4, 2022 03:52
@rliebz
Copy link
Member Author

rliebz commented Jan 4, 2022

@urfave/cli quick version bump if anyone is around to approve.

@rliebz
Copy link
Member Author

rliebz commented Jan 21, 2022

@saschagrunert @asahasrabuddhe if either of you have a minute to look this over, this fixes the broken pipeline in the main branch.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saschagrunert saschagrunert merged commit 5d61a2f into urfave:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants