Bump github.com/cpuguy83/go-md2man/v2 to v2.0.1 #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Also fix test expectation for man contents: dash and underscore are no longer escaped with backslash in go-md2man v2.0.1 See cpuguy83/go-md2man#74
anthonyfok
force-pushed
the
bump-go2man-to-v2.0.1
branch
from
cd56f39
to
60494b5
Compare
rliebz
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
github.com/cpuguy83/go-md2man/v2 v2.0.1 has been released with fixes, especially the following change which affects man page output:
It is good to bump our dependency on go-md2man to an official release from an old snapshot. For example, GitHub CLI https://github.com/cli/cl bumped dependency on go-md2man to v2.0.1 back in October 2021.
Which issue(s) this PR fixes:
None (no filed GitHub issue).
However, this PR fixes build/test error in Debian package golang-github-urfave-cli when built with go-md2man v2.0.1, failing at TestToMan, see:
Release Notes