Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous line from generated markdown #1311

Merged
merged 1 commit into from Nov 6, 2021
Merged

Conversation

jolheiser
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

This PR removes the extraneous man-page line from markdown rendering. It does this by only including the line if SectionNum > 0

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1275

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

go test -v ./...

Release Notes

(REQUIRED)

None.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser requested a review from a team as a code owner October 27, 2021 17:08
@rliebz rliebz merged commit 12b7dfd into urfave:master Nov 6, 2021
@jolheiser jolheiser deleted the md branch November 8, 2021 14:26
@codefromthecrypt
Copy link

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 bug: Man page section interferes with Markdown rendering
3 participants