Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Include Description and UsageText in docs output #1287

Merged
merged 1 commit into from Jul 7, 2021
Merged

feat(docs): Include Description and UsageText in docs output #1287

merged 1 commit into from Jul 7, 2021

Conversation

subpop
Copy link
Contributor

@subpop subpop commented Jun 30, 2021

What type of PR is this?

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

Include both UsageText and Description during doc generation.

Which issue(s) this PR fixes:

Fixes #1286

Testing

Included updates and a new unit test.

Release Notes

* Include both App.Description and App.UsageText in generated documentation output.

Include Description as part of the DESCRIPTION section, and put UsageText (if it is non-zero) into the Usage subsection.
@subpop subpop requested a review from a team as a code owner June 30, 2021 17:57
Copy link
Member

@rliebz rliebz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for the contribution!

@rliebz rliebz merged commit 6373f5b into urfave:master Jul 7, 2021
@subpop subpop deleted the description-markdown branch July 7, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 feature: Use app.Description in templates
2 participants