Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub action #1270

Merged
merged 1 commit into from Apr 24, 2021
Merged

Update GitHub action #1270

merged 1 commit into from Apr 24, 2021

Conversation

rliebz
Copy link
Member

@rliebz rliebz commented Apr 24, 2021

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

Bump go version to 1.16 and drop the codecov token, which is now
documented as not required for public repositories.

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1269

Special notes for your reviewer:

(fill-in or delete this section)

Figured I'd bump the go version while I was in there, but gfmrun failed, and I figured it was better to get this change in now and work that out later, so that's still at 1.15.

Testing

(fill-in or delete this section)

If the pipeline passes, we're golden.

Release Notes

(REQUIRED)

NONE

@rliebz rliebz requested a review from a team as a code owner April 24, 2021 16:28
Bump go version to 1.16 and drop the codecov token, which is now
documented as not required for public repositories.
@rliebz
Copy link
Member Author

rliebz commented Apr 24, 2021

@lynncyrin Once we get this merged in, we should revoke the token from whatever account owns it. Looking at #986 I'm guessing that's something you have access to.

@coilysiren
Copy link
Member

I do have access to it! 👍

Copy link
Member

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏽

@rliebz rliebz merged commit b1a2d96 into urfave:master Apr 24, 2021
@rliebz rliebz deleted the no-cov-token branch April 24, 2021 16:44
@coilysiren
Copy link
Member

Token revoked ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Potential Secret Leak
2 participants