Cleanup context.go #1264
Merged
Cleanup context.go #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearchap
requested review from
saschagrunert and
asahasrabuddhe
and removed request for
a team
rliebz
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Trying to make sure that function calls of the type someFoo(something, ctx) are part of receiver of ctx as (ctx *Context) someFoo(something). The error interfaces that were defined in context.go were shifted to errors.go. This makes the code more logical and clean. This is one step in making the code more modular.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
No logic was changed. This is a simple rearranging of the code to make it more structured. No new tests were added. Existing tests remain the same but with new function signatures for ctx methods.
Testing
go test ./...
Release Notes
None.