Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(issue #631). Remove reflect calls for Hidden field #1258

Merged
merged 1 commit into from Apr 24, 2021

Conversation

dearchap
Copy link
Contributor

What type of PR is this?

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

This removes the burden of having to use reflect calls to enforce hidden flag functionality. This makes the interface for Visible flags explicit rather than assuming that the user will have a field name "Hidden" in their flag implementation

Which issue(s) this PR fixes:

Fixes #631

Special notes for your reviewer:

Testing

go test ./...

Release Notes

User flag implementation need to implement VisibleFlag interface to allow their custom flags to be hidden/visible


@dearchap dearchap requested a review from a team as a code owner March 26, 2021 00:49
@dearchap dearchap requested review from rliebz and coilysiren and removed request for a team March 26, 2021 00:49
@coilysiren coilysiren requested review from a team and removed request for coilysiren and a team April 23, 2021 19:46
@rliebz rliebz merged commit e79ceb6 into urfave:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate reflection calls in flags
2 participants