UsageText to be passed from Command to App in startApp #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpacifying
requested review from
saschagrunert and
rliebz
and removed request for
a team
|
Bumping. Can someone take a look? Change is trivial, but it would help the project I am working on. |
rliebz
approved these changes
Apr 20, 2021
|
@rliebz thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
startApp function assigns Command fields to App fields, but UsageText field is missing. Because of that, this field is not presented correctly when viewing help for command having subcommands.
Which issue(s) this PR fixes:
I have found no open issues.
Release Notes