Add Destination field to TimestampFlag #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `Destination` field for the `TimestampFlag` type that allows you to specify a pointer to a `Timestamp` rather than having to grab the `Timestamp` from the `cli.Context` using the flag name.
davidsbond
requested review from
rliebz and
asahasrabuddhe
and removed request for
a team
rliebz
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds a
Destinationfield for theTimestampFlagtype that allows you to specify a pointer toa
Timestamprather than having to grab theTimestampfrom thecli.Contextusing the flagname.
Also updates the
expecttest helper to not useruntime.Calleretc directly. Instead, it callst.Helperbeforehand, which does the same thing. This is optional, but I think removes some unnecessary code. Happy to omit if preferred.Testing
Added a unit test
TestTimestampFlagApply_WithDestinationRelease Notes