Accept multi-value input on slice flags #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipally
requested review from
rliebz and
coilysiren
and removed request for
a team
3 tasks
coilysiren
requested review from
a team
and removed request for
rliebz and
coilysiren
|
This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else. |
|
Closing this as it has become stale. |
|
@vipally @coilysiren Can you reopen this PR. It would be really useful in our case. |
|
You can just bump it before it gets closed as stale???????? |
|
I'm going to reopen it but you have to actually do something about it if you don't want it to just get closed again |
meatballhat
changed the title
meatballhat
added
kind/bug
meatballhat
added a commit
that referenced
this pull request
Apr 26, 2022
Accept multi-value input on slice flags (#1241)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
fix v2 bug: accept multi-value input on sclice flags.
Which issue(s) this PR fixes:
Fixes #1238
Testing
TestFlagValue has cover this case.
Release Notes