bug fix #1235 : default value changes with parsed values on slice flags #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipally
requested review from
saschagrunert and
coilysiren
and removed request for
a team
dearchap
previously approved these changes
Mar 28, 2021
coilysiren
requested review from
a team
and removed request for
saschagrunert and
coilysiren
rliebz
previously approved these changes
Apr 24, 2021
rliebz
force-pushed
the
ally_fix_default_val
branch
from
df67478
to
ab52d6f
Compare
rliebz
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
As issue #1235 describes, this bug make the help info confuse, this PR fix this bug.
The SliceFlag hold on a pointer of a struct, when flagSet parse it, the DefaultValue changes,
so pass SliceFlag by a copy-value to flagSet for parse.
Which issue(s) this PR fixes:
Fixes #1235
Testing
A new test case TestFlagDefaultValue was added to flag_test.go
Release Notes