Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to godoc for v2 #1228

Merged
merged 2 commits into from Jan 28, 2021
Merged

Link to godoc for v2 #1228

merged 2 commits into from Jan 28, 2021

Conversation

zwass
Copy link
Contributor

@zwass zwass commented Jan 27, 2021

What type of PR is this?

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

This is consistent with the default tag for the repository.

Release Notes

Does not require a release note

This is consistent with the default tag for the repository.
@zwass zwass requested a review from a team as a code owner January 27, 2021 17:30
@zwass zwass requested review from rliebz and asahasrabuddhe and removed request for a team January 27, 2021 17:30
Copy link
Member

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zwass
Copy link
Contributor Author

zwass commented Jan 28, 2021

Ahh, I see. I have the "always use pkg.go.dev" setting on so it works after the redirect. Let's just use the direct link to pkg.go.dev?

Copy link
Member

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coilysiren coilysiren merged commit de20a55 into urfave:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants