make the man page section selectable #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobuhiro11
requested review from
saschagrunert and
rliebz
and removed request for
a team
coilysiren
requested changes
Jan 25, 2021
|
@lynncyrin I respect your opinion about the default section number. Since Go does not support the optional argument, I would like to work on one of the following implementations.
|
This one sounds best! |
bobuhiro11
force-pushed
the
fix_man_section
branch
from
a6a5f77
to
25e94ac
Compare
|
@lynncyrin Thanks! I've submitted a new patch. |
coilysiren
requested changes
Jan 27, 2021
bobuhiro11
force-pushed
the
fix_man_section
branch
from
25e94ac
to
9d658a4
Compare
Signed-off-by: Nobuhiro MIKI <nob@bobuhiro11.net>
bobuhiro11
force-pushed
the
fix_man_section
branch
from
9d658a4
to
ed2ee4b
Compare
|
@lynncyrin Coverage has improved. Can you please check again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The section number of the man page is fixed to 8.
This number can take other values depending on the usage.
https://www.man7.org/linux/man-pages/man7/man-pages.7.html
This fix adds a new argument to the
ToMarkdownandToManmethods so that they can be set to arbitrary values.If you prefer other implementation, please let me know.
Testing
Existing test code has been reused.
Release Notes