fix: Propagate App.Reader to subcommands #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change copies the `Reader` set in `App` to the new `App` created for subcommands. I've also added a basic test to demonstrate the issue.
Coderlane
requested review from
saschagrunert and
rliebz
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This change copies the
Readerset inAppto the newAppcreated for subcommands. This allows tests for subcommands to inject a reader, similar to first level commands. Previously, the reader for subcommands was reset toStdin. I added a basic test to demonstrate the issue.Which issue(s) this PR fixes:
(REQUIRED)
No issue yet
Testing
I added a test case that acts as a regression test.
Release Notes
(REQUIRED)