Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for parent context not setting child flags #1214

Merged
merged 6 commits into from Jan 29, 2021

Conversation

anicoll
Copy link
Contributor

@anicoll anicoll commented Dec 9, 2020

What type of PR is this?

  • [ x] bug

What this PR does / why we need it:

It fixes a simple bug for parent contexts not setting specific flags (IntSlice, Int64Slice)

Which issue(s) this PR fixes:

Fixes #1213

Release Notes

* Fixes an issue with flags being set by parent context's (`IntSlice`, `Int64Slice`)

@anicoll anicoll marked this pull request as ready for review December 9, 2020 11:34
@anicoll anicoll requested a review from a team as a code owner December 9, 2020 11:34
@anicoll anicoll requested review from rliebz and coilysiren and removed request for a team December 9, 2020 11:34
@@ -649,7 +649,7 @@ func main() {

app := &cli.App{
Action: func(c *cli.Context) error {
fmt.Println("yaml ist rad")
fmt.Println("--test value.*default: 0")
Copy link
Contributor Author

@anicoll anicoll Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for this part. I am not really sure whats happening here I just tried a few things locally to get the tests to pass. Seems like they fail on master rather than any change I have made.

Please let me know if you would like me to revert this change.

@anicoll
Copy link
Contributor Author

anicoll commented Jan 5, 2021

Any movement on this one?

rliebz
rliebz previously approved these changes Jan 6, 2021
@coilysiren
Copy link
Member

@anicoll Can you pull in the default branch to fix the failing test please 🙏🏼

@coilysiren
Copy link
Member

Actually, I was incorrect, it looks like codecov is what's failing 👀

@anicoll
Copy link
Contributor Author

anicoll commented Jan 27, 2021

@lynncyrin fixed. :)

Copy link
Member

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚚

@rliebz rliebz merged commit 498b50b into urfave:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 bug: Flags unavailable in child Context for IntSlice & Int64Slice (sub commands)
3 participants