New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for parent context not setting child flags #1214
Conversation
…to resolve the failing doc test
@@ -649,7 +649,7 @@ func main() { | |||
|
|||
app := &cli.App{ | |||
Action: func(c *cli.Context) error { | |||
fmt.Println("yaml ist rad") | |||
fmt.Println("--test value.*default: 0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies for this part. I am not really sure whats happening here I just tried a few things locally to get the tests to pass. Seems like they fail on master rather than any change I have made.
Please let me know if you would like me to revert this change.
Any movement on this one? |
@anicoll Can you pull in the default branch to fix the failing test please 🙏🏼 |
Actually, I was incorrect, it looks like codecov is what's failing 👀 |
@lynncyrin fixed. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚚
What type of PR is this?
What this PR does / why we need it:
It fixes a simple bug for parent contexts not setting specific flags (
IntSlice
,Int64Slice
)Which issue(s) this PR fixes:
Fixes #1213
Release Notes