Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows/cli.yml. #1212

Merged
merged 1 commit into from Dec 7, 2020
Merged

Conversation

jcgregorio
Copy link
Contributor

The ::set-env and ::add-path commands no longer work and need to
to be replaced. See:

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

What type of PR is this?

(REQUIRED)

  • [ x ] bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

PR checks currently don't run, this will fix that.

Which issue(s) this PR fixes:

(REQUIRED)

NONE

Release Notes

(REQUIRED)

NONE

The ::set-env and ::add-path commands no longer work and need to
to be replaced. See:

    https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
@jcgregorio jcgregorio requested a review from a team as a code owner December 6, 2020 15:02
@jcgregorio jcgregorio requested review from saschagrunert and asahasrabuddhe and removed request for a team December 6, 2020 15:02
Copy link
Member

@rliebz rliebz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Member

@asahasrabuddhe asahasrabuddhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asahasrabuddhe asahasrabuddhe merged commit d583313 into urfave:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants