Fix Context.Value. #1210
Merged
Fix Context.Value. #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcgregorio
requested review from
saschagrunert and
coilysiren
and removed request for
a team
saschagrunert
previously approved these changes
Dec 6, 2020
rliebz
previously approved these changes
Dec 6, 2020
jcgregorio
force-pushed
the
fix-context-value
branch
from
3609c3a
to
72037cf
Compare
|
Rebased to force checks to run. |
rliebz
previously approved these changes
Dec 8, 2020
|
Sorry @saschagrunert, I think I cancelled your approval when I pushed a new patch. |
|
Ping. |
|
@jcgregorio Can you pull in the default branch to fix the failing test please 🙏🏼 |
Before this change the added test would crash on a nil pointer dereference because the original code would only look in the local fileSet and not across all the fileSets.
jcgregorio
force-pushed
the
fix-context-value
branch
from
22cde86
to
d56c85c
Compare
|
@lynncyrin Done! |
rliebz
approved these changes
Jan 29, 2021
bodymovin
pushed a commit
to bodymovin/skia-buildbot
that referenced
this pull request
Feb 18, 2021
Now that urfave/cli#1210 has landed. Change-Id: If8bffcb2e470e2d7285a4d2c8f1672650f0ec43f Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/363156 Auto-Submit: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Context.Value so that it looks across all fileSets when looking for the named flag.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Before this change the added test would crash on a nil
pointer dereference because the original code would
only look in the local fileSet and not across all
the fileSets.
Which issue(s) this PR fixes:
(REQUIRED)
NONE
Testing
Added a test for Value, it currently had no test in context_test.go.
Without this change the test will crash.
Release Notes
(REQUIRED)