Display (accepts multiple inputs) in the help description for Slice flags.
#1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the help description.
Madhur1997
requested review from
saschagrunert and
coilysiren
and removed request for
a team
|
bumping this |
|
Failing check is unrelated. |
|
@Madhur1997 Can you pull in the default branch to fix the failing test please 🙏🏼 |
|
sure, updated the PR. Thanks for the review. |
coilysiren
approved these changes
Jan 28, 2021
rliebz
approved these changes
Jan 29, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
For Slice flags, display an additional string
(accepts multiple inputs)in the help description. This PR adds a support for itand updates existing tests for accommodating this change.
Which issue(s) this PR fixes:
Fixes #1066
Testing
Updated Existing tests to accommodate the changes.
Release Notes