How to implement something like an OptionFlag?

[marcofranssen]

How to implement something like an OptionFlag

I'm looking to implement a Flag which can have a few predefined values.

E.g.

mycli --output json
mycli --output xml

Is there a way to implement this using the existing flags while also informing the user of the cli what are the available options?

If not would it make sense to add this OptionFlag? I would be happy to make a PR for that with some guidance.

[coilysiren]

To rephrase the question - are if asking if there's a builtin way to implement a flag that gives users a set of choices from a predefined list? Something like Choices: []string{'json', 'xml'}?

[marcofranssen]

@lynncyrin yes that is exactly what I meant.

[coilysiren]

Makes sense! There's no obvious builtin way to implement this, but I've implemented a few "manual" versions of it. I don't happen to have that code on-hand, though.

[marcofranssen]

@lynncyrin would be great if you could dig it up and share a snippet here with the community. I'm happy to take that snippet of your further to integrate it here.

[MarvinJWendt]

Ping @lynncyrin

[nielsvaneck]

This was previously requested in #620

[stale]

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

[MarvinJWendt]

Not stale

[stale]

This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant.

[dearchap]

Here is how I implemented it using GenericFlag and a custom value

https://play.golang.org/p/BWBaQ0tTLKe

[dearchap]

There is a PR for this feature. #1234

[stale]

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

[stale]

Closing this as it has become stale.

[abdennour]

Wy Wy Wy! should we open it again?

[dearchap]

There are 2 ways to approach this. One is with PR #1234 . The other is using validations as in PR #1261 . Its upto the maintainers to choose the way forward.

[stale]

This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant.

[dearchap]

This is a duplicate of #786 .