Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks examples has an excessively long quote #184

Closed
matildepark opened this issue Oct 5, 2022 · 5 comments · Fixed by #193
Closed

Marks examples has an excessively long quote #184

matildepark opened this issue Oct 5, 2022 · 5 comments · Fixed by #193
Assignees

Comments

@matildepark
Copy link
Contributor

See all the green — this can't be right, can it? Surely we're missing a " somewhere.

https://developers.urbit.org/reference/arvo/clay/marks/examples#libcsvhoon

@tinnus-napbus
Copy link
Contributor

it's not missing anything, the syntax highlighter just can't handle escaped double-quotes inside double-quotes. I have tweaked the code to circumvent this syntax highlighter bug

@matildepark
Copy link
Contributor Author

I need to go fix this in prism (unless I already did and we just need to update prism now?)

@tinnus-napbus
Copy link
Contributor

oh yeah true, I will reopen. The logic should be "don't count \" unless the backslash itself is escaped eg \\"". Same logic for single-quotes inside single quotes. Also anything inside {}s inside double-quotes should not be counted unless the { is escaped

@tinnus-napbus tinnus-napbus reopened this Oct 10, 2022
@matildepark
Copy link
Contributor Author

Yeah, I definitely fixed this upstream, I need to go look at versioning in FDS and see if we just pull prism again.

@matildepark
Copy link
Contributor Author

Upstream pushed the escaped string fix in 1.29.0, which released in August. We were using 1.28.0 in FDS and on our sites, which released in April. I have bumped the version in both FDS and on developers.urbit.org, which should alleviate this in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants