Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does the SDK work for the browser? #62

Open
hrgui opened this issue Aug 24, 2021 · 0 comments
Open

How does the SDK work for the browser? #62

hrgui opened this issue Aug 24, 2021 · 0 comments

Comments

@hrgui
Copy link

hrgui commented Aug 24, 2021

Description

In the README.md, it states that this SDK works in the browser.

Supported platforms
This SDK can be used on both browser and Node.js environments.

However, it requires a client_id and client_secret.

As per https://uphold.com/en/developer/api/documentation/#registering-an-application:

Security Notice: Your Client Secret should never be shared, must be kept secret at all times and should only be used from your server-side application.

Using it in the browser can potentially expose the client ID and client secret through the JavaScript files. This contradicts how this can be used in the browser - unless I am missing something?

Is there any examples that use this SDK in a browser-based way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant