Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bundle to have multiple entries #150

Open
samijaber opened this issue Dec 3, 2020 · 1 comment
Open

Allow bundle to have multiple entries #150

samijaber opened this issue Dec 3, 2020 · 1 comment

Comments

@samijaber
Copy link
Contributor

We would like to export internals for our own usage under unsplash-js/internals instead of polluting the main unsplash-js scope and increasing bundle size for all consumers.

This should be doable in rollup, but we're using tsdx which has a bug around this feature: jaredpalmer/tsdx#175

See #149 for more details.

@OliverJAsh
Copy link
Member

If the consumer is using tree shaking then the new internals module shouldn't pollute the bundle size, as long as they don't import anything from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants