Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special case the file: protocol #204

Merged
merged 1 commit into from May 18, 2021
Merged

Special case the file: protocol #204

merged 1 commit into from May 18, 2021

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 14, 2021

Fixes #203

@krassowski krassowski mentioned this pull request May 17, 2021
Closed
@lpinca lpinca merged commit d2979b5 into master May 18, 2021
@lpinca lpinca deleted the fix/issue-203 branch May 18, 2021 05:00
@lpinca
Copy link
Member Author

lpinca commented May 18, 2021

@3rd-Eden @Swaagie can you please cut a new release? I can't publish to npm.

@lpinca lpinca mentioned this pull request May 29, 2021
Closed
@krassowski
Copy link

Looking forward to a new release :)

@pcafstockf
Copy link

ldap:///
I believe the same special case is needed for ldap (see https://ldap.com/ldap-urls/).

I can open a new issue if you like?
Just added a comment here, in case you wanted to bundle it into this PR ?

@lpinca
Copy link
Member Author

lpinca commented Jul 13, 2021

@pcafstockf see #205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect protocol/hostname parsing
3 participants
@lpinca @krassowski @pcafstockf