Skip to content

fix: Ensure build failure on emscripten install failure on Windows #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: Ensure build failure on emscripten install failure on Windows #666

merged 1 commit into from
Jan 30, 2023
+26 −1

Conversation

jeromelaban
Copy link
Member

@jeromelaban jeromelaban commented Jan 30, 2023 •
edited
Loading

closes #658

@jeromelaban jeromelaban merged commit 60f510d into main Jan 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/jela/build-failure branch January 30, 2023 20:04
@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/7.0

@mergify mergify bot mentioned this pull request Jan 30, 2023
Merged
@mergify
Copy link

mergify bot commented Jan 30, 2023

backport release/stable/7.0

✅ Backports have been created

jeromelaban added a commit that referenced this pull request Jan 31, 2023
@jeromelaban
Merge pull request #668 from unoplatform/mergify/bp/release/stable/7.…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f42b841 
…0/pr-666

fix: Ensure build failure on emscripten install failure on Windows (backport #666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emscripten installation failure does not fail the build
1 participant
@jeromelaban