Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add revision number to identify rebuild of the same version #2494

Open
5 of 10 tasks
nicholasdille opened this issue Jan 11, 2024 · 0 comments
Open
5 of 10 tasks

Add revision number to identify rebuild of the same version #2494

nicholasdille opened this issue Jan 11, 2024 · 0 comments

Comments

@nicholasdille
Copy link
Contributor

nicholasdille commented Jan 11, 2024 •
edited

  • Unknown: How to record the build number during a pipeline run?
    • Where is it stored?
      • File tools/TOOL/manifest.yaml?
      • Container image uniget-org/tools/metadata?
    • Is a commit necessary?
      Yes
    • If so, how will the subsequently triggered pipeline be handled or can/should it be
      suppressed?
      Using the job token does not trigger a pipeline.
  • Unknown: When to record the build number?
    • When testing PRs in .github/workflows/check.yml?
      Tests should be isolated.
    • When promoting updates to main in .github/workflows/tag.yml?
      Also targets direct commits to main
  • Add field build to schema
  • Rebuilds of the same version must increase the build field
  • Version bumps must reset the build field to 1 or remove it
  • Assume build to be 1 if absent
  • Update .github/workflows/tag.yml to increment build (or add build: 1 if absent)
  • Record build in version marker file (/var/lib/uniget/TOOL/1.2.3)
  • During installation, compare the value of the build field with the values stored in the marker file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicholasdille