Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ndarray dependency in segmenter to a release version #2280

Closed
aethanyc opened this issue Jul 29, 2022 · 2 comments · Fixed by #2299
Closed

Migrate ndarray dependency in segmenter to a release version #2280

aethanyc opened this issue Jul 29, 2022 · 2 comments · Fixed by #2299
Assignees
@aethanyc
Labels
C-segmentation Component: Segmentation
Milestone
ICU4X 1.0 (Final)

Comments

@aethanyc
Copy link
Contributor

We'll have to switch ndarray dependency in segmenter to a release version in order to publish icu_segmenter. The release must contain Makoto's fix in rust-ndarray/ndarray@3124410.

@sffc suggests we upload ndarray as icu_ndarray as a workaround until the upstream releases a new version.

cc @makotokato
@aethanyc aethanyc added the C-segmentation Component: Segmentation label Jul 29, 2022
@sffc sffc added this to the ICU4X 1.0 (Final) milestone Jul 30, 2022
@sffc
Copy link
Member

sffc commented Jul 31, 2022

Can we try upgrading to 0.15.5?

rust-ndarray/ndarray#1154 (comment)

@sffc
Copy link
Member

sffc commented Jul 31, 2022

@aethanyc Assigning this to you to try using the new version

@aethanyc aethanyc mentioned this issue Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aethanyc aethanyc

Labels
C-segmentation Component: Segmentation
Projects
None yet
Milestone
ICU4X 1.0 (Final)
Development

Successfully merging a pull request may close this issue.

Use ndarray 0.15 instead of a commit hash aethanyc/icu4x
2 participants
@aethanyc @sffc