Add AnyProvider #1495
Add AnyProvider #1495
Conversation
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
^ this is a rebase in order to pull in the new ZCF |
sffc
requested review from
gregtatum,
nordzilla,
zbraniecki and
a team
as code owners
|
The commit history is a big mess, but the final result should be fairly clean. I removed erased.rs and replaced it with any.rs. The two files ended up being more similar than I had anticipated, but AnyProvider is more up-to-date with our latest design. I also rewrote StructProvider to operate on AnyPayloads. This makes it much more flexible, as can be seen in the DateTimeFormat test refactoring included in this PR. It may be desirable to rename the |
|
The types I ended up with are as follows:
|
| for<'a> YokeTraitHack<<M::Yokeable as Yokeable<'a>>::Output>: Clone, | ||
| M::Yokeable: ZeroCopyFrom<'static, M::Yokeable>, | ||
| { | ||
| self.try_unwrap_owned()?.downcast() |
There was a problem hiding this comment.
question: are we ever in danger from users manually constructing non-owned anypayloads?
(i know the current code has this too)
There was a problem hiding this comment.
I added a test to demonstrate how one could trigger this code path to run.
| pub key: ResourceKey, | ||
| pub data: DataPayload<M>, | ||
| pub data: AnyPayload, |
There was a problem hiding this comment.
thought(nb): These fields being public are fine but it might be nice API-wise to have a convenient constructor
There was a problem hiding this comment.
This is a pre-existing issue, and I may make further revisions to this class after I do the other issues I have lined up, so I would rather not add a constructor right now.
Fixes #1479
This is a work-in-progress. Still to-do: