Add API for padding to a minimum number of decimal digits #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sffc
requested changes
Jan 7, 2022
sffc
reviewed
Jan 8, 2022
sffc
requested changes
Jan 11, 2022
There was a problem hiding this comment.
I'd like the FixedDecimal class to be robust against integer overflow because we have actually had problems with this in ICU. Whenever you add, subtract, or cast these things, you should handle the overflow. See my suggestions. Ideally we also have test cases for these.
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
sffc
reviewed
Jan 11, 2022
| } | ||
|
|
||
| // how many digits need to be deleted from the start. | ||
| let cut = self.magnitude - self.upper_magnitude; | ||
| self.upper_magnitude = magnitude; |
There was a problem hiding this comment.
Nit: add
#[cfg(debug_assertions)]
self.check_invariants();There was a problem hiding this comment.
Still not here yet. Please add the check_invariants in all three functions (pad left, pad right, truncate left).
Also please fix the clippy warning. :)
sffc
previously approved these changes
Jan 11, 2022
|
Filed #1496 for now |
sffc
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1476
I'm not sure what to name this. Honestly I think that we should name this API
minimum_decimal_digitsinstead (and maybe get rid of the padding API?). I don't see truncation as particularly useful. Overall from talking to the WearOS users they do prefer to think in terms of "minimum" and "maximum" digits.