Add EitherProvider and rename IterableDataProviderCore to IterableProvider #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Dec 31, 2021
| /// .or_else(|err| DataProviderB::or_else_supports_key(err, resc_key)) | ||
| /// .or_else(|err| DataProviderC::or_else_supports_key(err, resc_key)) | ||
| /// ``` | ||
| fn or_else_supports_key(err: DataError, resc_key: &ResourceKey) -> Result<(), DataError> { |
There was a problem hiding this comment.
nit: i'd call this chainable_supports_key() or something, the or_else makes it feel like it's doing something else, whereas it really means that it's supposed to be used inside or_else.
(i know this is an existing naming choice, but i just noticed it. feel free to ignore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves
KeyedDataProviderinto the CLDR crate since it has limited use outside of the core crate and I'd like to replace it with something better (see #442).