Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing ListFormatter &str inputs by W: Writeable #1438

Merged
merged 23 commits into from
Jan 19, 2022
Merged

Replacing ListFormatter &str inputs by W: Writeable #1438

merged 23 commits into from
Jan 19, 2022

Conversation

robertbastian
Copy link
Member

No description provided.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • utils/writeable/src/impls.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc
sffc requested changes Dec 29, 2021
View reviewed changes
experimental/list_formatter/src/provider.rs Outdated Show resolved Hide resolved
experimental/list_formatter/src/list_formatter.rs Outdated Show resolved Hide resolved
experimental/list_formatter/src/list_formatter.rs Outdated Show resolved Hide resolved
experimental/list_formatter/src/list_formatter.rs Outdated Show resolved Hide resolved
@sffc sffc mentioned this pull request Dec 30, 2021
Merged
@robertbastian
Copy link
Member Author

I'll wait for #1452

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.lock is different
  • experimental/list_formatter/src/list_formatter.rs is different
  • experimental/list_formatter/src/provider.rs is different
  • provider/cldr/src/transform/list/mod.rs is different
  • utils/writeable/src/impls.rs is different
  • utils/writeable/src/lib.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.lock is different
  • experimental/list_formatter/Cargo.toml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@robertbastian robertbastian changed the title Replacing ListFormatter &str inputs by &W: Writeable Replacing ListFormatter &str inputs by W: Writeable Dec 30, 2021
@robertbastian robertbastian changed the title Replacing ListFormatter &str inputs by W: Writeable Replacing ListFormatter &str inputs by W: FormattedWriteable Jan 5, 2022
sffc
sffc reviewed Jan 5, 2022
View reviewed changes
experimental/formatted_string/src/lib.rs Outdated Show resolved Hide resolved
experimental/formatted_string/src/lib.rs Outdated Show resolved Hide resolved
experimental/formatted_string/src/lib.rs Outdated Show resolved Hide resolved
experimental/formatted_string/src/formatted_string.rs Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.lock is different
  • experimental/list_formatter/Cargo.toml is different
  • experimental/list_formatter/examples/and_list.rs is different
  • provider/cldr/src/transform/list/mod.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc sffc self-requested a review January 6, 2022 19:24
sffc
sffc previously approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Still more feedback, but you're welcomet o merge this PR and do it in a follow-up.

experimental/list_formatter/src/list_formatter.rs Outdated Show resolved Hide resolved
experimental/list_formatter/examples/and_list.rs Outdated Show resolved Hide resolved
experimental/list_formatter/src/list_formatter.rs Show resolved Hide resolved
experimental/list_formatter/src/list_formatter.rs Outdated Show resolved Hide resolved
experimental/list_formatter/src/provider.rs Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.lock is different
  • experimental/list_formatter/Cargo.toml is different
  • experimental/list_formatter/src/provider.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc
sffc previously approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since I want to get this checked in, but I still think there's room for more design work. This stuff is hard!

@robertbastian robertbastian changed the title Replacing ListFormatter &str inputs by W: FormattedWriteable Replacing ListFormatter &str inputs by W: Writeable Jan 9, 2022
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.lock is different
  • Cargo.toml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc
sffc approved these changes Jan 19, 2022
View reviewed changes
utils/writeable/src/lib.rs
Comment on lines +286 to +287
#[doc(hidden)] // Macro use only
pub mod formatted_string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Put this on the top of the file with the other mods / imports

@robertbastian robertbastian merged commit 3dc1535 into unicode-org:main Jan 19, 2022
@robertbastian robertbastian deleted the append branch January 19, 2022 17:46
@robertbastian robertbastian linked an issue Jan 20, 2022 that may be closed by this pull request
Add FormattedStringBuilder #135
Closed
@robertbastian robertbastian mentioned this pull request Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@nordzilla nordzilla Awaiting requested review from nordzilla

@Manishearth Manishearth Awaiting requested review from Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FormattedStringBuilder
4 participants
@robertbastian @sffc @Manishearth @nordzilla