Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename resource key category for properties #1406

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Dec 16, 2021

Fixes #1196

@@ -25,7 +25,7 @@ pub mod key {
($allkeys:ident; $count:expr; $(($k:ident, $s:literal)),+,) => {
$(
#[allow(missing_docs)] // These constants don't need individual documentation.
pub const $k: ResourceKey = resource_key!(UnicodeSet, $s, 1);
pub const $k: ResourceKey = resource_key!(Properties, $s, 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run cargo make testdata

@echeran echeran marked this pull request as ready for review December 16, 2021 23:15
@echeran echeran requested review from Manishearth and a team as code owners December 16, 2021 23:15
@echeran echeran merged commit 294c66f into unicode-org:main Dec 16, 2021
@echeran echeran deleted the rename-props-datakey branch December 16, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss data key category for properties resources
2 participants