Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error in method From of MetaZoneSpecificNamesV1 #1405

Merged
merged 1 commit into from
Jan 8, 2022
Merged

fix error in method From of MetaZoneSpecificNamesV1 #1405

merged 1 commit into from
Jan 8, 2022

Conversation

samchen61661
Copy link
Member

@samchen61661 samchen61661 commented Dec 16, 2021 •
edited

Fix an error in method From of MetaZoneSpecificNamesV1.

We want to remove generic key but map size should not be larger than 1.

@samchen61661 samchen61661 requested review from nordzilla, sffc and a team as code owners December 16, 2021 00:28
nordzilla
nordzilla previously approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@nordzilla nordzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@samchen61661 samchen61661 changed the title fix error in From of MetaZoneSpecificNamesV1 fix error in method From of MetaZoneSpecificNamesV1 Jan 4, 2022
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • provider/testdata/data/testdata.postcard is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@nordzilla nordzilla self-requested a review January 6, 2022 17:04
nordzilla
nordzilla previously approved these changes Jan 6, 2022
View reviewed changes
@nordzilla nordzilla added C-datetime Component: datetime, calendars, time zones S-tiny Size: Less than an hour (trivial fixes) T-bug Type: Bad behavior, security, privacy labels Jan 6, 2022
@nordzilla nordzilla added this to the 2021 Q4 0.5 Sprint E milestone Jan 6, 2022
sffc
sffc previously approved these changes Jan 7, 2022
View reviewed changes
@samchen61661 samchen61661 dismissed stale reviews from sffc and nordzilla via e7611ac January 7, 2022 23:32
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .idea/.gitignore is now changed in the branch
  • .idea/icu4x.iml is now changed in the branch
  • .idea/modules.xml is now changed in the branch
  • .idea/vcs.xml is now changed in the branch
  • provider/testdata/data/testdata.postcard is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@nordzilla nordzilla self-requested a review January 7, 2022 23:36
nordzilla
nordzilla requested changes Jan 7, 2022
View reviewed changes
Copy link
Member

@nordzilla nordzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samchen61661

It looks like the most recent rebase accidentally added some .idea files.

@nordzilla nordzilla reopened this Jan 8, 2022
@nordzilla nordzilla merged commit 899c90f into unicode-org:main Jan 8, 2022
@nordzilla nordzilla mentioned this pull request Jan 27, 2022
Merged
@samchen61661 samchen61661 deleted the fix-error branch April 6, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordzilla nordzilla nordzilla approved these changes

@sffc sffc sffc left review comments

Assignees
No one assigned
Labels
C-datetime Component: datetime, calendars, time zones S-tiny Size: Less than an hour (trivial fixes) T-bug Type: Bad behavior, security, privacy
Projects
None yet
Milestone
2021 Q4 0.5 Sprint E
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samchen61661 @sffc @nordzilla