Replace SerdeDeDataProvider with BufferProvider #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Dec 9, 2021
Manishearth
previously approved these changes
Dec 9, 2021
Manishearth
previously approved these changes
Dec 9, 2021
Manishearth
approved these changes
Dec 9, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #837
Progress on #1107
See #1246
This is a large-ish PR but it is mostly refactoring. I couldn't make it smaller in any meaningful way. I suggest looking at the whole PR rather than commit-by-commit, because my commits are rather messy.
I deleted
SerdeDeDataProviderand replaced it withBufferProvider. I also moved the deserialization code from provider_fs and moved it into the core provider crate behind feature flags.I added a field to
DataResponseMetadatathat specifies the buffer format for Serde to deserialize.I did not yet remove the deserialization code from provider_blob. However, the change should be extremely small now. I just wanted to save that for another PR since it affects FFI signatures, and I want to be very careful about how it affects binary size. #1368