Add a resolve_components method to DateTimeFormat #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for feature compatibility with ECMA-402. The backing DateTimeFormat implementation needs to be able to return the resolved components from the given options. These resolved components can differ based on locale or the resolution algorithm.
gregtatum
commented
Dec 6, 2021
| @@ -489,6 +492,183 @@ impl From<TimeZoneName> for Field { | |||
| } | |||
| } | |||
|
|
|||
| /// Get the resolved components for a DateTimeFormat, via the PatternPlurals. In the case of | |||
| /// plurals resolve off of the required `other` pattern. | |||
| impl<'data> From<&PatternPlurals<'data>> for Bag { | |||
There was a problem hiding this comment.
The components::Bag is a little weird to return here, but seems more maintainable than creating a separate ResolvedComponents type, since the return information fully fit into the existing struct.
nordzilla
approved these changes
Dec 9, 2021
| _ => Numeric::Numeric, | ||
| }, | ||
| fields::Second::FractionalSecond => { | ||
| unimplemented!("fields::Second::FractionalSecond. #1360") |
There was a problem hiding this comment.
praise
Thanks for providing strings to all of the unimplemented!() macro calls, and also for adding issue numbers where relevant.
sffc
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for feature compatibility with ECMA-402. The backing
DateTimeFormat implementation needs to be able to return the resolved
components from the given options. These resolved components can differ
based on locale or the resolution algorithm.
Resolves #1361