Implement data transformer for Script_Extensions map data #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… VarZeroVec type parameter
Manishearth
reviewed
Dec 3, 2021
There was a problem hiding this comment.
looks good so far, with #1357 you won't need the custom ULE type and .get_as_zv() would need to be changed, but also you might just not need it since ZeroVecULE<T> has a lot of useful methods already
Branch 'zv-ule' is not yet merged, but simplifies VZV<[T]> into VZV<ZVULE<T>>
…roVecULE and methods
sffc
reviewed
Dec 11, 2021
sffc
reviewed
Dec 11, 2021
Co-authored-by: Shane F. Carr <shane@unicode.org>
…at were removed before merge to main
…&ZeroSlice w/o referencing fn local data
3 tasks
… from Vec<Vec<u16> to VZV<ZS<Script>>
…th short alias instead of long alias
sffc
reviewed
Dec 16, 2021
sffc
approved these changes
Dec 16, 2021
sffc
reviewed
Dec 16, 2021
| @@ -321,3 +321,12 @@ impl<T: AsULE> AsRef<ZeroSlice<T>> for Vec<T::ULE> { | |||
| ZeroSlice::<T>::from_ule_slice(&**self) | |||
| } | |||
| } | |||
|
|
|||
| impl<T> Default for &ZeroSlice<T> | |||
There was a problem hiding this comment.
FYI @Manishearth : We are adding a impl Default for &ZeroSlice
echeran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is progress towards #1271