Julian calendar

[pandusonu2]

Partially fixes #1119

[Manishearth]

good start!

[jira-pull-request-webhook]

Notice: the branch changed across the force-push!

• components/calendar/src/iso.rs is different
• components/calendar/src/julian.rs is different
• components/calendar/src/lib.rs is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[pandusonu2]

@Manishearth sorry for force push, just redid the PR, so would be better to check from start.

[Manishearth]

I think this is good! I would prefer if the offsetting code was shared, and there's some confusion around exactly what the logical types are, but we should be able to land this soon!

[pandusonu2]

Ive added algorithms according to the book in 10585a5

But I don't really like it......
Alternative suggestion: revert 10585a5 and merge the code before that, and work on julian<->fixed integer time<->iso in another PR if we want to use that kind of conventions

[Manishearth]

Bunch of mistakes when copying over the algorithm, but the structure seems right!

[pandusonu2]

Ive added algorithms according to the book in 10585a5

But I don't really like it...... Alternative suggestion: revert 10585a5 and merge the code before that, and work on julian<->fixed integer time<->iso in another PR if we want to use that kind of conventions

I guess it was just a matter of rereading the algorithm multiple times till it made sense. Fine with the current changes (-.-)>

[Manishearth]

Your testcases are passing now, yes?

[pandusonu2]

Your testcases are passing now, yes?

Yes

[Manishearth]

Alright, thanks! Hopefully once we get the CalendarArithmetic stuff done it becomes way easier to add calendars