Add GC predicate functions #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested changes
Nov 17, 2021
components/properties/src/maps.rs
Outdated
Comment on lines
248
to
251
| pub fn is_cased_letter(gc_map: &CodePointTrie<GeneralSubcategory>, code_point: u32) -> bool { | ||
| let gc_val = gc_map.get(code_point); | ||
| 0 != (gc_val as u32) & GeneralCategory::CasedLetter.0 | ||
| } |
There was a problem hiding this comment.
Two other ways:
impl GeneralSubcategory {
pub fn is_contained(gc: GeneralCategory) -> bool {
// do the test
}
}impl GeneralCategory {
pub fn contains(gsc: GeneralSubcategory) -> bool {
// opposite of above
}
}There was a problem hiding this comment.
Done before a previous review. Took the second approach.
components/properties/src/maps.rs
Outdated
| /// ``` | ||
| pub fn is_letter(gc_map: &CodePointTrie<GeneralSubcategory>, code_point: u32) -> bool { | ||
| let gc_val = gc_map.get(code_point); | ||
| 0 != (gc_val as u32) & GeneralCategory::Letter.0 |
There was a problem hiding this comment.
Suggested change
| 0 != (gc_val as u32) & GeneralCategory::Letter.0 | |
| 0 != (1 << (gc_val as u32)) & GeneralCategory::Letter.0 |
There was a problem hiding this comment.
Done before a previous review.
sffc
previously approved these changes
Nov 22, 2021
Co-authored-by: Shane F. Carr <shane@unicode.org>
sffc
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1158