Add Buddhist calendar calculations #1305
Conversation
components/calendar/src/buddhist.rs
Outdated
| pub struct BuddhistDateInner(IsoDateInner); | ||
|
|
||
| impl Calendar for Buddhist { | ||
| type DateInner = BuddhistDateInner; |
There was a problem hiding this comment.
Suggestion: just make DateInner = IsoDateInner. Why do we need the wrapper?
| era: types::Era(tinystr8!("be")), | ||
| number: buddhist_year, |
There was a problem hiding this comment.
Question: this creates negative years in the "be" era. Is that correct, or is there a BCE-like era in this calendar?
There was a problem hiding this comment.
It's "correct" in that the calendar is not supposed to be used for past dates, but we already decided that we won't support cutoff dates for calendars and instead will fall back to negative eras.
There was a problem hiding this comment.
That's right; I was asking if this calendar system has an era for old dates, something like "BBE" (before buddhist era)? If not, then negative dates in the current era is fine.
|
oops, did not intend to rerequest a review |
This is basically rhe same implementation as the gregorian calendar with a different zero year.
Fixes #1118