Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double-to-decimal for FixedDecimal via ryū #1217

Merged
merged 35 commits into from
Nov 10, 2021
Merged

Add double-to-decimal for FixedDecimal via ryū #1217

merged 35 commits into from
Nov 10, 2021

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 26, 2021 •
edited

fixes #166

This adds two functions instead of just one with a trait since it doesn't seem worth it to pull in the num_traits crate just for .is_finite().

@Manishearth Manishearth requested review from sffc and a team as code owners October 26, 2021 22:43
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • ffi/diplomat/c/include/result_box_ICU4XFixedDecimal_void.h is now changed in the branch
  • ffi/diplomat/cpp/include/result_box_ICU4XFixedDecimal_void.h is now changed in the branch
  • utils/fixed_decimal/src/decimal.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • ffi/diplomat/c/include/result_box_ICU4XFixedDecimal_void.h is no longer changed in the branch
  • ffi/diplomat/cpp/include/result_box_ICU4XFixedDecimal_void.h is no longer changed in the branch
  • utils/fixed_decimal/src/decimal.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@Manishearth Manishearth changed the title Add double-to-decimal for FixedDecimal Add double-to-decimal for FixedDecimal via ryū Oct 27, 2021
sffc
sffc previously requested changes Oct 28, 2021
View reviewed changes
utils/fixed_decimal/src/decimal.rs Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.lock is different
  • ffi/diplomat/Cargo.toml is different
  • ffi/diplomat/cpp/include/ICU4XFixedDecimal.hpp is different
  • utils/fixed_decimal/Cargo.toml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@Manishearth Manishearth marked this pull request as draft November 4, 2021 18:26
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • ffi/diplomat/c/include/ICU4XFixedDecimal.h is no longer changed in the branch
  • ffi/diplomat/Cargo.toml is no longer changed in the branch
  • ffi/diplomat/cpp/docs/source/fixed_decimal_ffi.rst is no longer changed in the branch
  • ffi/diplomat/cpp/examples/fixeddecimal/test.cpp is no longer changed in the branch
  • ffi/diplomat/cpp/include/ICU4XFixedDecimal.h is no longer changed in the branch
  • ffi/diplomat/cpp/include/ICU4XFixedDecimal.hpp is no longer changed in the branch
  • ffi/diplomat/src/fixed_decimal.rs is no longer changed in the branch
  • ffi/diplomat/wasm/docs/fixed_decimal_ffi.rst is no longer changed in the branch
  • ffi/diplomat/wasm/lib/api.mjs is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • utils/fixed_decimal/src/decimal.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@Manishearth Manishearth requested a review from sffc November 8, 2021 21:42
@Manishearth Manishearth requested a review from sffc November 9, 2021 20:03
@Manishearth @sffc
Update utils/fixed_decimal/src/decimal.rs
6c6b6f4 
Co-authored-by: Shane F. Carr <shane@unicode.org>
@Manishearth Manishearth requested a review from sffc November 9, 2021 21:35
sffc
sffc reviewed Nov 9, 2021
View reviewed changes
utils/fixed_decimal/src/decimal.rs Outdated Show resolved Hide resolved
utils/fixed_decimal/src/decimal.rs Outdated Show resolved Hide resolved
utils/fixed_decimal/src/decimal.rs Outdated Show resolved Hide resolved
@Manishearth Manishearth requested a review from sffc November 9, 2021 22:23
sffc
sffc reviewed Nov 9, 2021
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting on a fix to my comment about trailing zeros in self.digits

@Manishearth Manishearth requested a review from sffc November 9, 2021 22:49
sffc
sffc reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes since I last reviewed

@Manishearth
Copy link
Member Author

Argh, it rejected my push

sffc
sffc reviewed Nov 10, 2021
View reviewed changes
utils/fixed_decimal/src/decimal.rs Outdated Show resolved Hide resolved
utils/fixed_decimal/src/decimal.rs Outdated Show resolved Hide resolved
@Manishearth Manishearth merged commit 8a99635 into unicode-org:main Nov 10, 2021
@Manishearth Manishearth deleted the ryu-fd branch November 10, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double-to-decimal in ICU4X
2 participants
@Manishearth @sffc