[UNDERTOW-1615] Remove unused dependencies #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hi, @cesarsotovalero ! Thanks for your PR, it will soon be tested! |
|
This is ok to test |
fl4via
added
waiting CI check
fl4via
changed the title
fl4via
added
next release
fl4via
approved these changes
Nov 15, 2019
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I noticed that dependencies
undertow-servlet,undertow-websockets-jsr,jboss-logging-processor,xnio-nio,jmh-generator-annprocess, andhttpmimeare declared in thepomof theundertow-benchmarksmodule. However, these dependencies are not used in any of the four classes of the module. Removing these unused dependencies in thepomhas an impact on the size of the packaged jar file for the benchmarks (reduction is more than 1MB), and also decreases the complexity of the Maven dependency tree of the module.