[UNDERTOW-1833] Unneccessary code removed from the test. #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a trivial change of removal unused and unnecessary code in the Http2EndExchangeTestCase.java test case. Apart from that, I slightly changed the way how test fails in case that HTTP2 connection is not correctly established - I unified this failure with other failures in the test. There is no other problem in the test as it is passing just fine. I just got around this when I was investigating something else.
jstourac
force-pushed
the
minorTestUpdate
branch
from
9fd95a8
to
e50a7e5
Compare
|
Regarding to the CI job results - I don't think that failures there are related to changes in this PR. |
|
@jstourac Thanks for your PR! We've been working sistematically between one task and another to fix the failures, they are probably unrelated, I'll double check. |
fl4via
added
enhancement
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/UNDERTOW-1833
This is a trivial change of removal unused and unnecessary code in
the Http2EndExchangeTestCase.java test case.
Apart from that, I slightly changed the way how test fails in case that
HTTP2 connection is not correctly established - I unified this failure
with other failures in the test.
There is no other problem in the test as it is passing just fine.
I just got around this when I was investigating something else.