New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for LCOV output #68
Comments
Is there a description of this format somewhere? |
The move towards GitHub Actions for CI in kubernetes-el#146 removed code coverage tracking via Coveralls, which until now had come "for free" via Travis. This PR reintroduces Coveralls tracking via the guidance in [undercover](https://github.com/undercover-el/undercover.el) documentation. Unfortunately, this only enables tracking, but does not provide feedback in PR of changes to test coverage like before. Were undercover to integrate LCOV reporting support (see undercover-el/undercover.el#68), this could then move to using [the official Coveralls GitHub Action](https://github.com/marketplace/actions/coveralls-github-action), which would give that reporting.
There's a general description of the expected format here. There's also some related discussion in nedbat/coveragepy#587 that might be useful. |
The move towards GitHub Actions for CI in #146 removed code coverage tracking via Coveralls, which until now had come "for free" via Travis. This PR reintroduces Coveralls tracking via the guidance in [undercover](https://github.com/undercover-el/undercover.el) documentation. Unfortunately, this only enables tracking, but does not provide feedback in PR of changes to test coverage like before. Were undercover to integrate LCOV reporting support (see undercover-el/undercover.el#68), this could then move to using [the official Coveralls GitHub Action](https://github.com/marketplace/actions/coveralls-github-action), which would give that reporting.
Do you know if it's sufficient to emit only |
Seems to work, can you try it? In (development
...
(depends-on "undercover"
:git "https://github.com/undercover-el/undercover.el"
:branch "next")) And then as described here. |
Thanks for looking into this. I implemented a setup similar to the integration example repo you created for a project I contribute to. However, I seem to be getting the following issue in the Coveralls Action:
Details and implementation can be found here. Let me know if there's any other information I can provide that might be useful. |
Thanks for testing, that problem should now be fixed. |
Excellent, looks like that did the trick. Let me know how else I can assist. |
If everything looks good to you so far, let me know and I'll push to master and tag a release. |
Looks good to me—doesn't look like there's anything out of the ordinary in the reporting in Coveralls for my repo. I'm not in a position to comment on the undercover.el implementation itself, so I'll happily defer to you on that. Looking forward to the release. Thanks again for looking into this. |
OK, here it is: https://github.com/undercover-el/undercover.el/releases/tag/v0.8.1
Your appreciation is appreciated :) |
Awesome, I think we can close this issue now. 👏 |
It would be nice to have the option to output the coverage report as LCOV. This would allow for compatibility with Coveralls' own GitHub Action, which would allow for native reporting of test coverage in the PR itself.
The text was updated successfully, but these errors were encountered: