Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable require config cache #11230

Closed
wants to merge 1 commit into from
Closed

Conversation

fz6m
Copy link
Member

@fz6m fz6m commented Jun 2, 2023

fix #11226

目前由于不同的 stage ,都会读取配置,但有的阶段需要 schema 校验有的不需要,这会导致多次读取、运行配置。

为了解多次运行,思路是缓存一下。

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umi-docs ❌ Failed (Inspect) Jun 2, 2023 3:16pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Jun 2, 2023 3:16pm

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (27937cd) 29.15% compared to head (6ff9d13) 29.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11230      +/-   ##
==========================================
+ Coverage   29.15%   29.18%   +0.03%     
==========================================
  Files         483      483              
  Lines       14607    14615       +8     
  Branches     3447     3448       +1     
==========================================
+ Hits         4258     4266       +8     
  Misses       9601     9601              
  Partials      748      748              
Impacted Files Coverage Δ
packages/core/src/service/service.ts 62.77% <ø> (ø)
packages/core/src/config/config.ts 67.22% <100.00%> (+2.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sorrycc sorrycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

会不会导致 dev 时刷配置不生效?

@fz6m
Copy link
Member Author

fz6m commented Jun 12, 2023

先关闭这个 PR ,目前发现每次获得到的全新 config 会导致 config diff 总是失效,从而 routes 更改无法热更新。

先挂起这个问题,以后有想法再解。

@fz6m fz6m closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: .umirc.ts文件执行两遍
2 participants